linux-kernel - Re: [PATCH v3 03/10] eventfs: adding eventfs dir add functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1C0CB205-B56F-44AE-B9B4-3668E06C840E@vmware.com>
Date:   Mon, 10 Jul 2023 02:17:01 +0000
From:   Nadav Amit <namit@...are.com>
To:     Steven Rostedt <rostedt@...dmis.org>
CC:     Ajay Kaher <akaher@...are.com>,
        "mhiramat@...nel.org" <mhiramat@...nel.org>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-trace-kernel@...r.kernel.org" 
        <linux-trace-kernel@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org <linux-kselftest@...r.kernel.org> ,
        Ching-lin Yu <chinglinyu@...gle.com> , Nadav Amit <namit@...are.com> ,
        srivatsa@...il.mit.edu <srivatsa@...il.mit.edu> , Alexey Makhalov
        <amakhalov@...are.com> , Vasavi Sirnapalli <vsirnapalli@...are.com>,
        Tapas Kundu <tkundu@...are.com>, er.ajay.kaher@...il.com
        <linux-trace-kernel@...r.kernel.org> , linux-kselftest@...r.kernel.org
        <linux-kselftest@...r.kernel.org> , Ching-lin Yu <chinglinyu@...gle.com>
        , Nadav Amit <namit@...are.com> , sri" <er.ajay.kaher@...il.com>
Subject: Re: [PATCH v3 03/10] eventfs: adding eventfs dir add functions


> On Jul 9, 2023, at 6:54 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> +       union {
> +               struct rcu_head         rcu;
> +               struct llist_node       llist;  /* For freeing after RCU */
> +       };

The memory savings from using a union might not be worth the potential impact
of type confusion and bugs.