linux-kernel - Re: [PATCH 1/8] fpga: bridge: Convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZKvDfNWGB3DJMkJ8@yilunxu-OptiPlex-7050>
Date:   Mon, 10 Jul 2023 16:38:20 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     Yangtao Li <frank.li@...o.com>
Cc:     Moritz Fischer <mdf@...nel.org>, Wu Hao <hao.wu@...el.com>,
        Tom Rix <trix@...hat.com>, linux-fpga@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/8] fpga: bridge: Convert to
 devm_platform_ioremap_resource()

On 2023-07-05 at 17:46:48 +0800, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>

Acked-by: Xu Yilun <yilun.xu@...el.com>

Applied.

> ---
>  drivers/fpga/altera-freeze-bridge.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/fpga/altera-freeze-bridge.c b/drivers/fpga/altera-freeze-bridge.c
> index 445f4b011167..bb6b02ec2d21 100644
> --- a/drivers/fpga/altera-freeze-bridge.c
> +++ b/drivers/fpga/altera-freeze-bridge.c
> @@ -213,14 +213,12 @@ static int altera_freeze_br_probe(struct platform_device *pdev)
>  	void __iomem *base_addr;
>  	struct altera_freeze_br_data *priv;
>  	struct fpga_bridge *br;
> -	struct resource *res;
>  	u32 status, revision;
>  
>  	if (!np)
>  		return -ENODEV;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base_addr = devm_ioremap_resource(dev, res);
> +	base_addr = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(base_addr))
>  		return PTR_ERR(base_addr);
>  
> -- 
> 2.39.0
>