linux-kernel - Re: [PATCH 3/8] fpga: dfl-fme-mgr: Convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZKvDpkSNt5aTQXhs@yilunxu-OptiPlex-7050>
Date:   Mon, 10 Jul 2023 16:39:02 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     Yangtao Li <frank.li@...o.com>
Cc:     Wu Hao <hao.wu@...el.com>, Tom Rix <trix@...hat.com>,
        Moritz Fischer <mdf@...nel.org>, linux-fpga@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/8] fpga: dfl-fme-mgr: Convert to
 devm_platform_ioremap_resource()

On 2023-07-05 at 17:46:50 +0800, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>

Acked-by: Xu Yilun <yilun.xu@...el.com>

Applied.

> ---
>  drivers/fpga/dfl-fme-mgr.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c
> index af0785783b52..ab228d8837a0 100644
> --- a/drivers/fpga/dfl-fme-mgr.c
> +++ b/drivers/fpga/dfl-fme-mgr.c
> @@ -280,7 +280,6 @@ static int fme_mgr_probe(struct platform_device *pdev)
>  	struct device *dev = &pdev->dev;
>  	struct fme_mgr_priv *priv;
>  	struct fpga_manager *mgr;
> -	struct resource *res;
>  
>  	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
>  	if (!priv)
> @@ -290,8 +289,7 @@ static int fme_mgr_probe(struct platform_device *pdev)
>  		priv->ioaddr = pdata->ioaddr;
>  
>  	if (!priv->ioaddr) {
> -		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -		priv->ioaddr = devm_ioremap_resource(dev, res);
> +		priv->ioaddr = devm_platform_ioremap_resource(pdev, 0);
>  		if (IS_ERR(priv->ioaddr))
>  			return PTR_ERR(priv->ioaddr);
>  	}
> -- 
> 2.39.0
>