linux-kernel - Re: [RFC PATCH] wifi: iwlwifi: remove 'use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Jul 2023 18:16:17 +0800
From:   Jeff Chua <jeff.chua.linux@...il.com>
To:     "Zhang, Rui" <rui.zhang@...el.com>
Cc:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "johannes@...solutions.net" <johannes@...solutions.net>,
        "Berg, Johannes" <johannes.berg@...el.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        Gregory Greenman <gregory.greenman@...el.com>,
        Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Linux Networking <netdev@...r.kernel.org>,
        Bagas Sanjaya <bagasdotme@...il.com>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] wifi: iwlwifi: remove 'use_tfh' config to fix crash

On Mon, Jul 10, 2023 at 9:53 AM Zhang, Rui <rui.zhang@...el.com> wrote:
>
> On Sun, 2023-07-09 at 20:13 +0200, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@...el.com>
> >
> > This is equivalent to 'gen2', and it's confusing to have two
> > of the same configs. The split config patch actually had been
> > originally developed after this, and didn't add the use_tfh
> > in the new configs because they were copied to the new files
> > after ...
> >
> > There's clearly still an unwind error in iwl_txq_gen2_init()
> > since it crashes if something fails there, but the reason it
> > fails in the first place is due to the gen2/use_tfh confusion.
> >
> > Reported-by: Jeff Chua <jeff.chua.linux@...il.com>
> > Reported-by: "Zhang, Rui" <rui.zhang@...el.com>
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217622
> > Link:
> > https://lore.kernel.org/all/9274d9bd3d080a457649ff5addcc1726f08ef5b2.camel@xry111.site/
> > Link:
> > https://lore.kernel.org/all/CAAJw_Zug6VCS5ZqTWaFSr9sd85k%3DtyPm9DEE%2BmV%3DAKoECZM%2BsQ@mail.gmail.com/
> > Fixes: 19898ce9cf8a ("wifi: iwlwifi: split 22000.c into multiple
> > files")
> > Signed-off-by: Johannes Berg <johannes.berg@...el.com>
>
> Hi, Johannes,
>
> Thanks for the patch. It fixes the problem on my side.
>
> Tested-by: Zhang Rui <rui.zhang@...el.com>
>
> thanks,
> rui


Johannes,

Fixed as well! Thank you!

cc to those I've posted before as well.

Jeff