[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dc2abecb-c3c6-0265-4352-89737b26de66@ti.com>
Date: Mon, 10 Jul 2023 16:44:16 +0530
From: Ravi Gunasekaran <r-gunasekaran@...com>
To: Frank Li <Frank.Li@....com>
CC: <Thinh.Nguyen@...opsys.com>, <andriy.shevchenko@...ux.intel.com>,
<gregkh@...uxfoundation.org>, <imx@...ts.linux.dev>,
<jgilab@...il.com>, <jun.li@....com>,
<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
<peter.chen@...nel.org>, <quic_eserrao@...cinc.com>,
<quic_prashk@...cinc.com>, <rogerq@...nel.org>
Subject: Re: [PATCH v2 2/2] usb: cdns3: fix incorrect calculation of
ep_buf_size when more than one config
On 7/8/23 4:30 AM, Frank Li wrote:
> Previously, the cdns3_gadget_check_config() function in the cdns3 driver
> mistakenly calculated the ep_buf_size by considering only one
> configuration's endpoint information because "claimed" will be clear after
> call usb_gadget_check_config().
>
> The fix involves checking the private flags EP_CLAIMED instead of relying
> on the "claimed" flag.
>
> Fixes: dce49449e04f ("usb: cdns3: allocate TX FIFO size according to composite EP number")
> Reported-by: Ravi Gunasekaran <r-gunasekaran@...com>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> drivers/usb/cdns3/cdns3-gadget.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c
> index ccfaebca6faa..3326955f6991 100644
> --- a/drivers/usb/cdns3/cdns3-gadget.c
> +++ b/drivers/usb/cdns3/cdns3-gadget.c
> @@ -2999,12 +2999,14 @@ static int cdns3_gadget_udc_stop(struct usb_gadget *gadget)
> static int cdns3_gadget_check_config(struct usb_gadget *gadget)
> {
> struct cdns3_device *priv_dev = gadget_to_cdns3_device(gadget);
> + struct cdns3_endpoint *priv_ep;
> struct usb_ep *ep;
> int n_in = 0;
> int total;
>
> list_for_each_entry(ep, &gadget->ep_list, ep_list) {
> - if (ep->claimed && (ep->address & USB_DIR_IN))
> + priv_ep = ep_to_cdns3_ep(ep);
> + if ((priv_ep->flags & EP_CLAIMED) && (ep->address & USB_DIR_IN))
> n_in++;
> }
>
Tested-by: Ravi Gunasekaran <r-gunasekaran@...com>
--
Regards,
Ravi
Powered by blists - more mailing lists