linux-kernel - Re: [PATCH v2 1/2] usb: gadget: call usb_gadget_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZL/eF0fZe4k63sXX@lizhi-Precision-Tower-5810>
Date:   Tue, 25 Jul 2023 10:37:11 -0400
From:   Frank Li <Frank.li@....com>
To:     Thinh.Nguyen@...opsys.com, andriy.shevchenko@...ux.intel.com,
        gregkh@...uxfoundation.org, imx@...ts.linux.dev, jgilab@...il.com,
        jun.li@....com, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, peter.chen@...nel.org,
        quic_eserrao@...cinc.com, quic_prashk@...cinc.com,
        r-gunasekaran@...com, rogerq@...nel.org
Subject: Re: [PATCH v2 1/2] usb: gadget: call usb_gadget_check_config() to
 verify UDC capability

On Fri, Jul 07, 2023 at 07:00:14PM -0400, Frank Li wrote:
> The legacy gadget driver omitted calling usb_gadget_check_config()
> to ensure that the USB device controller (UDC) has adequate resources,
> including sufficient endpoint numbers and types, to support the given
> configuration.
> 
> Previously, usb_add_config() was solely invoked by the legacy gadget
> driver. Adds the necessary usb_gadget_check_config() after the bind()
> operation to fix the issue.
> 
> Fixes: dce49449e04f ("usb: cdns3: allocate TX FIFO size according to composite EP number")
> Reported-by: Ravi Gunasekaran <r-gunasekaran@...com>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---

@greg
        ping

> change from v1 to v2
> - not change for this patch, just add new patch to fix multi-config case
> 
>  drivers/usb/gadget/composite.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index 403563c06477..cb0a4e2cdbb7 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -1029,6 +1029,10 @@ int usb_add_config(struct usb_composite_dev *cdev,
>  		goto done;
>  
>  	status = bind(config);
> +
> +	if (status == 0)
> +		status = usb_gadget_check_config(cdev->gadget);
> +
>  	if (status < 0) {
>  		while (!list_empty(&config->functions)) {
>  			struct usb_function		*f;
> -- 
> 2.34.1
>