linux-kernel - Re: [PATCH v2 1/2] usb: gadget: call usb_gadget_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023072501-primp-grandson-7f79@gregkh>
Date:   Tue, 25 Jul 2023 17:09:30 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Frank Li <Frank.li@....com>
Cc:     Thinh.Nguyen@...opsys.com, andriy.shevchenko@...ux.intel.com,
        imx@...ts.linux.dev, jgilab@...il.com, jun.li@....com,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        peter.chen@...nel.org, quic_eserrao@...cinc.com,
        quic_prashk@...cinc.com, r-gunasekaran@...com, rogerq@...nel.org
Subject: Re: [PATCH v2 1/2] usb: gadget: call usb_gadget_check_config() to
 verify UDC capability

On Tue, Jul 25, 2023 at 10:37:11AM -0400, Frank Li wrote:
> On Fri, Jul 07, 2023 at 07:00:14PM -0400, Frank Li wrote:
> > The legacy gadget driver omitted calling usb_gadget_check_config()
> > to ensure that the USB device controller (UDC) has adequate resources,
> > including sufficient endpoint numbers and types, to support the given
> > configuration.
> > 
> > Previously, usb_add_config() was solely invoked by the legacy gadget
> > driver. Adds the necessary usb_gadget_check_config() after the bind()
> > operation to fix the issue.
> > 
> > Fixes: dce49449e04f ("usb: cdns3: allocate TX FIFO size according to composite EP number")
> > Reported-by: Ravi Gunasekaran <r-gunasekaran@...com>
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> 
> @greg
>         ping

It's in my review queue, please give me a chance to catch up.

While you wait, doing review of other USB patches would be most
appreciated.

thanks,

greg k-h