linux-kernel - Re: [PATCH] tpm: return false from tpm_amd_is_rng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CTYJ2CJL0T5F.2L84F8XBD3Y6P@suppilovahvero>
Date:   Mon, 10 Jul 2023 16:31:04 +0300
From:   "Jarkko Sakkinen" <jarkko@...nel.org>
To:     "Jerry Snitselaar" <jsnitsel@...hat.com>,
        "Linux regressions mailing list" <regressions@...ts.linux.dev>
Cc:     <linux-kernel@...r.kernel.org>, <linux-integrity@...r.kernel.org>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        "Jason Gunthorpe" <jgg@...pe.ca>,
        "Peter Huewe" <peterhuewe@....de>, <stable@...r.kernel.org>,
        "Mario Limonciello" <mario.limonciello@....com>,
        "Aneesh Kumar K . V" <aneesh.kumar@...ux.ibm.com>,
        "Sachin Sant" <sachinp@...ux.ibm.com>
Subject: Re: [PATCH] tpm: return false from tpm_amd_is_rng_defective on
 non-x86 platforms

On Fri Jul 7, 2023 at 11:18 PM EEST, Jerry Snitselaar wrote:
> On Fri, Jul 07, 2023 at 06:07:49PM +0200, Linux regression tracking (Thorsten Leemhuis) wrote:
> > Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
> > for once, to make this easily accessible to everyone.
> > 
> > So what's the way forward now? It sounded like Jarkko wanted to apply
> > the patch from this thread days ago, but that didn't happen afaics. Then
> > below message showed up, but Marios patch also wasn't applied.
> > 
> > Is this intentional, or did something somewhere fall through the cracks?
> > 
> > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>
> I haven't seen any update to Jarkko's repo.
>
> My patch resolves the immediate issue being seen on the ppc system,
> and was mostly just me asking why even go through this amd specific
> code on non-x86 systems.
>
> The vio bus shutdown code only does the remove call when kexec is in
> progress. The pnp and platform bus type shutdown calls do not do
> something similar so maybe the check in Mario's patch isn't needed,
> but I don't think it would hurt to have it in there.

The patch has been applied. I'm sending pull request for rc2 today.

The merge window was a bit conflicting with the summer season, and
also relocating.

BR, Jarkko