linux-kernel - Re: [PATCH printk v2 4/5] printk: Add per-console suspended state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230711150819.GC12154@google.com>
Date:   Wed, 12 Jul 2023 00:08:19 +0900
From:   Sergey Senozhatsky <senozhatsky@...omium.org>
To:     John Ogness <john.ogness@...utronix.de>
Cc:     Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH printk v2 4/5] printk: Add per-console suspended state

On (23/07/10 15:51), John Ogness wrote:
[..]
> @@ -2623,8 +2647,6 @@ void console_lock(void)
>  		msleep(1000);
>  
>  	down_console_sem();
> -	if (console_suspended)
> -		return;
>  	console_locked = 1;
>  	console_may_schedule = 1;
>  }
> @@ -2645,10 +2667,6 @@ int console_trylock(void)
>  		return 0;
>  	if (down_trylock_console_sem())
>  		return 0;
> -	if (console_suspended) {
> -		up_console_sem();
> -		return 0;
> -	}
>  	console_locked = 1;
>  	console_may_schedule = 0;
>  	return 1;

Interesting. console_locked previously would not be set if
console is suspended, but now it's always set, which in theory
changes the way WARN_CONSOLE_UNLOCKED() macro works in some
cases?