[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZK15JNtBFU_7l30o@orome>
Date: Tue, 11 Jul 2023 17:45:40 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Guiting Shen <aarongt.shen@...il.com>
Cc: claudiu.beznea@...rochip.com, u.kleine-koenig@...gutronix.de,
nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
linux-arm-kernel@...ts.infradead.org, linux-pwm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: atmel: enable clk when pwm already enabled in
bootloader
On Tue, Jul 11, 2023 at 10:30:54AM +0800, Guiting Shen wrote:
> On Mon, Jul 10, 2023 at 23:00:45PM GMT+8, Thierry Reding wrote:
> > On Mon, Jul 10, 2023 at 10:42:14PM +0800, Guiting Shen wrote:
> >> The driver would never call clk_eanble() if the pwm channel already
> >> enable in bootloader which lead to dump the warning message of "the pwm
> >> clk already disabled" when poweroff the pwm channel.
> >>
> >> Add atmel_pwm_enanle_clk_if_on() in probe function to enable clk if the
> >> pwm channel already enabled in bootloader.
> >
> > You've got multiple spelling errors in the commit message. Also, PWM is
> > an abbreviation and so should be all uppercase (except for the subject
> > prefix). I also prefer spelling out terms like "clock" in the commit
> > message. This is text that is supposed to be readable. It's not code.
>
> Got it, Thank you. How about this commit message:
>
> The driver would never call clk_enable() if the PWM channel was already
> enabled in bootloader which lead to dump the warning message "the pwm
> clock already disabled" when turn off the PWM channel.
>
> Add atmel_pwm_enable_clk_if_on() in probe function to enable clk if the
> PWM channel was already enabled in bootloader.
s/clk/clock/ but otherwise looks good.
Thierry
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists