linux-kernel - Re: [PATCH] pwm: atmel: enable clk when pwm already enabled in bootloader

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230711073031.6jpcd6z7x2oeyg5r@pengutronix.de>
Date:   Tue, 11 Jul 2023 09:30:31 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Guiting Shen <aarongt.shen@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        claudiu.beznea@...rochip.com, nicolas.ferre@...rochip.com,
        alexandre.belloni@...tlin.com,
        linux-arm-kernel@...ts.infradead.org, linux-pwm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: atmel: enable clk when pwm already enabled in
 bootloader

On Tue, Jul 11, 2023 at 10:37:56AM +0800, Guiting Shen wrote:
> On Tue, Jul 11, 2023 at 03:15:50AM GMT+8, Uwe Kleine-König wrote:
> > Hello,
> > 
> > On Mon, Jul 10, 2023 at 05:00:45PM +0200, Thierry Reding wrote:
> >> On Mon, Jul 10, 2023 at 10:42:14PM +0800, Guiting Shen wrote:
> >>> +		err = clk_enable(atmel_pwm->clk);
> >>> +		if (err) {
> >>> +			dev_err(atmel_pwm->chip.dev, "enable clock error\n");
> >>
> >> Might be worth to include the error code in the error message to make it
> >> easier to diagnose where the issue is. Something like:
> >>
> >> 	dev_err(atmel_pwm->chip.dev, "failed to enable clock: %d\n", err);
> > 
> > Or (IMHO) still better:
> > 
> >  	dev_err(atmel_pwm->chip.dev, "failed to enable clock: %pe\n", ERR_PTR(err));
> > 
> 
> Ok, I will add it in v2 patch.
> 
> I also found that the clk_enable() of atmel_pwm_apply() do not include
> the error code in the error message. Do I also add this in v2 patch or
> in separate patch?

Sounds to me like a separate patch.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)