linux-kernel - Re: [PATCH v5 4/5] Revert "tracing: Add "(fault)" name injection to kernel probes"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Jul 2023 12:19:10 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc:     Dan Carpenter <dan.carpenter@...aro.org>,
        linux-trace-kernel@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 4/5] Revert "tracing: Add "(fault)" name injection to
 kernel probes"

On Tue, 11 Jul 2023 23:15:57 +0900
"Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:

> From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> 
> This reverts commit 2e9906f84fc7c99388bb7123ade167250d50f1c0.
> 
> It was turned out that commit 2e9906f84fc7 ("tracing: Add "(fault)"
> name injection to kernel probes") did not work correctly and probe
> events still show just '(fault)' (instead of '"(fault)"'). Also,
> current '(fault)' is more explicit that it faulted.
> 
> This also moves FAULT_STRING macro to trace.h so that synthetic
> event can keep using it, and uses it in trace_probe.c too.
> 
> Link: https://lore.kernel.org/all/20230706230642.3793a593@rorschach.local.home/
> 
> Cc: stable@...r.kernel.org
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Tom Zanussi <zanussi@...nel.org>
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> ---

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve