linux-kernel - Re: [PATCH v1 0/3] perf list: Remove duplicate PMUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <182675ca-0905-0ed2-de94-0f7d4a256082@oracle.com>
Date:   Tue, 11 Jul 2023 09:26:30 +0100
From:   John Garry <john.g.garry@...cle.com>
To:     Ian Rogers <irogers@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Ravi Bangoria <ravi.bangoria@....com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 0/3] perf list: Remove duplicate PMUs

On 11/07/2023 06:58, Ian Rogers wrote:
> When there are multiple PMUs differing by ordered suffixes only
> display one. This avoids repeated listing of events, in particular
> when there are 10s of uncore PMUs. This also helps speed the all PMU
> event tests.
> 
> Before:
> ```
> $ perf list
> ...
>    uncore_imc_free_running_0/data_read/               [Kernel PMU event]
>    uncore_imc_free_running_0/data_total/              [Kernel PMU event]
>    uncore_imc_free_running_0/data_write/              [Kernel PMU event]
>    uncore_imc_free_running_1/data_read/               [Kernel PMU event]
>    uncore_imc_free_running_1/data_total/              [Kernel PMU event]
>    uncore_imc_free_running_1/data_write/              [Kernel PMU event]
> ```
> 
> After:
> ```
> $ perf list
> ...
>    uncore_imc_free_running/data_read/                 [Kernel PMU event]
>    uncore_imc_free_running/data_total/                [Kernel PMU event]
>    uncore_imc_free_running/data_write/                [Kernel PMU event]

So with this change can we run something like:

perf stat -e uncore_imc_free_running/data_read/

?

If so, does that match all PMUs whose name beings with 
"uncore_imc_free_running" (and give aggregate result for those PMUs)?

Thanks,
John

> ```
> 
> The PMUs are sorted by name then suffix as a part of this change.
> 
> Ian Rogers (3):
>    perf pmus: Sort pmus by name then suffix
>    perf pmus: Add scan that ignores duplicates, use for perf list
>    perf pmus: Don't print PMU suffix in list
> 
>   tools/perf/util/pmus.c | 107 +++++++++++++++++++++++++++++++++++++++--
>   1 file changed, 102 insertions(+), 5 deletions(-)
>