[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cwqcmeqxglkd32crmc7fw57hhrrihtqnkle5ympniuthkg6j6w@fmyd7jxvffhi>
Date: Tue, 11 Jul 2023 13:21:39 +0200
From: Michal Koutný <mkoutny@...e.com>
To: Miaohe Lin <linmiaohe@...wei.com>
Cc: tj@...nel.org, hannes@...xchg.org, lizefan.x@...edance.com,
cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cgroup: remove unneeded return value of
cgroup_rm_cftypes_locked()
On Tue, Jul 11, 2023 at 10:58:48AM +0800, Miaohe Lin <linmiaohe@...wei.com> wrote:
> +/* It builds upon cgroup_addrm_files()'s. */
> static void cgroup_rm_cftypes_locked(struct cftype *cfts)
> {
> lockdep_assert_held(&cgroup_mutex);
>
I meant adding the reasoning to the commit message -- swallowing errors
on removal is fine because cgroup_addrm_files() won't fail at removal.
It's a minor remark for the future readers ;-)
Michal
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists