linux-kernel - Re: [PATCH] dt-bindings: hwmon: moortec, mr75203: fix multipleOf for coefficients

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d9a0899-145e-3223-41da-b91b81afaaa2@amazon.com>
Date:   Wed, 12 Jul 2023 14:58:14 +0300
From:   "Farber, Eliav" <farbere@...zon.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Rahul Tanwar <rtanwar@...linear.com>,
        <linux-hwmon@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <farbere@...zon.com>
Subject: Re: [PATCH] dt-bindings: hwmon: moortec, mr75203: fix multipleOf for
 coefficients

On 7/12/2023 11:11 AM, Krzysztof Kozlowski wrote:
> Few coefficients use default values multiple of 100, not 1000 (in the
> example DTS and in the Linux driver):
>
>  moortec,mr75203.example.dtb: pvt@...80000: moortec,ts-coeff-g:0:0: 
> 61400 is not a multiple of 1000

Why isn't multiple of 1000 correct?
According to the Moortec datasheet for the series 6 of the temperature 
sensor
the coefficients are:
G = 57.4 (57.4 * 1000 = 57400)
H = 249.4
For series 5 coefficients are:
G = 60 (60 * 1000 = 60000)
H = 200
J = -0.1

> Fixes: bf1fdafdbc61 ("dt-bindings: hwmon: (mr75203) add coefficient 
> properties for the thermal equation")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
> .../devicetree/bindings/hwmon/moortec,mr75203.yaml          | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git 
> a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml 
> b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> index ae4f68d4e696..bd67cfee6d19 100644
> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> @@ -105,7 +105,7 @@ properties:
>       G coefficient for temperature equation.
>       Default for series 5 = 60000
>       Default for series 6 = 57400
> -    multipleOf: 1000
> +    multipleOf: 100
>     minimum: 1000
>     $ref: /schemas/types.yaml#/definitions/uint32
>
> @@ -114,7 +114,7 @@ properties:
>       H coefficient for temperature equation.
>       Default for series 5 = 200000
>       Default for series 6 = 249400
> -    multipleOf: 1000
> +    multipleOf: 100
>     minimum: 1000
>     $ref: /schemas/types.yaml#/definitions/uint32
>
> @@ -131,7 +131,7 @@ properties:
>       J coefficient for temperature equation.
>       Default for series 5 = -100
>       Default for series 6 = 0
> -    multipleOf: 1000
> +    multipleOf: 100
>     maximum: 0
>     $ref: /schemas/types.yaml#/definitions/int32
>
> -- 
> 2.34.1
>