linux-kernel - Re: [PATCH] dt-bindings: hwmon: moortec, mr75203: fix multipleOf for coefficients

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Jul 2023 14:07:31 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "Farber, Eliav" <farbere@...zon.com>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Rahul Tanwar <rtanwar@...linear.com>,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: moortec, mr75203: fix multipleOf for
 coefficients

On 12/07/2023 13:58, Farber, Eliav wrote:
> On 7/12/2023 11:11 AM, Krzysztof Kozlowski wrote:
>> Few coefficients use default values multiple of 100, not 1000 (in the
>> example DTS and in the Linux driver):
>>
>>  moortec,mr75203.example.dtb: pvt@...80000: moortec,ts-coeff-g:0:0: 
>> 61400 is not a multiple of 1000
> 
> Why isn't multiple of 1000 correct?

61400 is not a multiple of 1000, at least not in integers. 61400 is a
multiple of 100.

> According to the Moortec datasheet for the series 6 of the temperature 
> sensor
> the coefficients are:
> G = 57.4 (57.4 * 1000 = 57400)

57.4 is not integer. With that approach 1 is also multiple of 1000, because:

G = 1 * 0.001 * 1000.

> H = 249.4
> For series 5 coefficients are:
> G = 60 (60 * 1000 = 60000)
> H = 200
> J = -0.1

Trim the context of replies. No need to quote entire text below.

Best regards,
Krzysztof