lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230713132140.azamscgceh6yyy6j@bogus>
Date:   Thu, 13 Jul 2023 14:21:40 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     stanley.chu@...iatek.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, matthias.bgg@...il.com,
        angelogioacchino.delregno@...labora.com,
        linux-scsi@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] scsi: ufs: ufs-mediatek: Remove surplus dev_err()

On Thu, Jul 13, 2023 at 02:11:23PM +0100, Sudeep Holla wrote:
> On Wed, Jul 12, 2023 at 02:48:32PM +0800, Yang Li wrote:
> > There is no need to call the dev_err() function directly to print a
> > custom message when handling an error from either the platform_get_irq()
> > or platform_get_irq_byname() functions as both are going to display an
> > appropriate error message in case of a failure.
> > 
> > ./drivers/ufs/host/ufs-mediatek.c:864:3-10: line 864 is redundant because platform_get_irq() already prints an error
> > 
> > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5846
> 
> Acked-by: Sudeep Holla <sudeep.holla@....com>
> 

Sorry for this, I didn't mean to ack this patch, no idea how on earth I
managed to do that (must be some wrong key combination in my email client)
but I wanted and meant to ack only this [1]. Sorry for the noise.

-- 
Regards,
Sudeep

[1] https://lore.kernel.org/r/20230712062853.11007-9-frank.li@vivo.com

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ