linux-kernel - Re: [PATCH -next] scsi: ufs: ufs-mediatek: Remove surplus dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1pm4i5syu.fsf@ca-mkp.ca.oracle.com>
Date:   Sun, 23 Jul 2023 15:27:26 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     stanley.chu@...iatek.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, matthias.bgg@...il.com,
        angelogioacchino.delregno@...labora.com,
        linux-scsi@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] scsi: ufs: ufs-mediatek: Remove surplus dev_err()


Yang,

> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.

Applied to 6.6/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering