linux-kernel - Re: [PATCH net v1] net:wireless:Fix an NULL vs IS_ERR() bug for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Jul 2023 08:58:01 -0700
From:   Jeff Johnson <quic_jjohnson@...cinc.com>
To:     Wang Ming <machel@...o.com>,
        Toke Høiland-Jørgensen <toke@...e.dk>,
        Kalle Valo <kvalo@...nel.org>,
        Rajkumar Manoharan <rmanoharan@...eros.com>,
        "John W. Linville" <linville@...driver.com>,
        Sujith Manoharan <Sujith.Manoharan@...eros.com>,
        <linux-wireless@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <opensource.kernel@...o.com>
Subject: Re: [PATCH net v1] net:wireless:Fix an NULL vs IS_ERR() bug for
 debugfs_create_dir()

correct subject prefix is "wifi: ath9k: "

On 7/12/2023 8:03 PM, Wang Ming wrote:
> The debugfs_create_dir() function returns error pointers,
> it never returns NULL. Most incorrect error checks were fixed,
> but the one in ath9k_htc_init_debug() was forgotten.
> 
> Fix the remaining error check.
> 
> Signed-off-by: Wang Ming <machel@...o.com>
> 
> Fixes: e5facc75fa91 ("ath9k_htc: Cleanup HTC debugfs")
> ---
>   drivers/net/wireless/ath/ath9k/htc_drv_debug.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_debug.c b/drivers/net/wireless/ath/ath9k/htc_drv_debug.c
> index b3ed65e5c4da..c55aab01fff5 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_debug.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_debug.c
> @@ -491,7 +491,7 @@ int ath9k_htc_init_debug(struct ath_hw *ah)
>   
>   	priv->debug.debugfs_phy = debugfs_create_dir(KBUILD_MODNAME,
>   					     priv->hw->wiphy->debugfsdir);
> -	if (!priv->debug.debugfs_phy)
> +	if (IS_ERR(priv->debug.debugfs_phy))
>   		return -ENOMEM;
>   
>   	ath9k_cmn_spectral_init_debug(&priv->spec_priv, priv->debug.debugfs_phy);