[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4b3512ee-ea9e-0d55-fa45-9a9f84832295@quicinc.com>
Date: Thu, 13 Jul 2023 09:00:01 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Minjie Du <duminjie@...o.com>, Jiri Slaby <jirislaby@...nel.org>,
Nick Kossifidis <mickflemm@...il.com>,
Luis Chamberlain <mcgrof@...nel.org>,
Kalle Valo <kvalo@...nel.org>,
"open list:ATHEROS ATH5K WIRELESS DRIVER"
<linux-wireless@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
CC: <opensource.kernel@...o.com>
Subject: Re: [PATCH v1] drivers: wireless: ath5k: fix parameter check in
ath5k_debug_init_device
subject prefix should be "wifi: ath5k: "
On 7/12/2023 5:42 AM, Minjie Du wrote:
> Make IS_ERR() judge the debugfs_create_dir() function return
> in ath5k_debug_init_device().
>
> Signed-off-by: Minjie Du <duminjie@...o.com>
> ---
> drivers/net/wireless/ath/ath5k/debug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c
> index 4b41160e5..08058b3f7 100644
> --- a/drivers/net/wireless/ath/ath5k/debug.c
> +++ b/drivers/net/wireless/ath/ath5k/debug.c
> @@ -982,7 +982,7 @@ ath5k_debug_init_device(struct ath5k_hw *ah)
> ah->debug.level = ath5k_debug;
>
> phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir);
> - if (!phydir)
> + if (IS_ERR(phydir))
> return;
>
> debugfs_create_file("debug", 0600, phydir, ah, &fops_debug);
Powered by blists - more mailing lists