[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230713033647.2109-1-duminjie@vivo.com>
Date: Thu, 13 Jul 2023 11:36:47 +0800
From: Minjie Du <duminjie@...o.com>
To: Jiri Slaby <jirislaby@...nel.org>,
Nick Kossifidis <mickflemm@...il.com>,
Luis Chamberlain <mcgrof@...nel.org>,
Kalle Valo <kvalo@...nel.org>,
linux-wireless@...r.kernel.org (open list:ATHEROS ATH5K WIRELESS DRIVER),
linux-kernel@...r.kernel.org (open list)
Cc: opensource.kernel@...o.com, Minjie Du <duminjie@...o.com>
Subject: [PATCH v2] drivers: wireless: ath5k: fix parameter check in ath5k_debug_init_device()
Make IS_ERR_OR_NULL() judge the debugfs_create_dir() function return
in ath5k_debug_init_device().
Signed-off-by: Minjie Du <duminjie@...o.com>
Acked-by: Luis Chamberlain <mcgrof@...nel.org>
---
v1-v2:
use IS_ERR_OR_NULL() instead of IS_ERR()
---
drivers/net/wireless/ath/ath5k/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c
index 4b41160e5..7c8823759 100644
--- a/drivers/net/wireless/ath/ath5k/debug.c
+++ b/drivers/net/wireless/ath/ath5k/debug.c
@@ -982,7 +982,7 @@ ath5k_debug_init_device(struct ath5k_hw *ah)
ah->debug.level = ath5k_debug;
phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir);
- if (!phydir)
+ if (IS_ERR_OR_NULL(phydir))
return;
debugfs_create_file("debug", 0600, phydir, ah, &fops_debug);
--
2.39.0
Powered by blists - more mailing lists