[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fcb9f467-d579-782a-80f7-68e14e98e1cd@kernel.org>
Date: Thu, 13 Jul 2023 07:14:26 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Minjie Du <duminjie@...o.com>,
Nick Kossifidis <mickflemm@...il.com>,
Luis Chamberlain <mcgrof@...nel.org>,
Kalle Valo <kvalo@...nel.org>,
"open list:ATHEROS ATH5K WIRELESS DRIVER"
<linux-wireless@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v2] drivers: wireless: ath5k: fix parameter check in
ath5k_debug_init_device()
On 13. 07. 23, 5:36, Minjie Du wrote:
> Make IS_ERR_OR_NULL() judge the debugfs_create_dir() function return
> in ath5k_debug_init_device().
>
> Signed-off-by: Minjie Du <duminjie@...o.com>
> Acked-by: Luis Chamberlain <mcgrof@...nel.org>
> ---
> v1-v2:
> use IS_ERR_OR_NULL() instead of IS_ERR()
> ---
> drivers/net/wireless/ath/ath5k/debug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c
> index 4b41160e5..7c8823759 100644
> --- a/drivers/net/wireless/ath/ath5k/debug.c
> +++ b/drivers/net/wireless/ath/ath5k/debug.c
> @@ -982,7 +982,7 @@ ath5k_debug_init_device(struct ath5k_hw *ah)
> ah->debug.level = ath5k_debug;
>
> phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir);
> - if (!phydir)
> + if (IS_ERR_OR_NULL(phydir))
When can debugfs_create_dir() return NULL?
> return;
>
> debugfs_create_file("debug", 0600, phydir, ah, &fops_debug);
--
js
suse labs
Powered by blists - more mailing lists