linux-kernel - Re: [PATCH] dt-bindings: net: xilinx_gmii2rgmii: Convert to json schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd0fb281-b621-4d6b-be94-be6095e35328@lunn.ch>
Date:   Thu, 13 Jul 2023 21:30:04 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Pranavi Somisetty <pranavi.somisetty@....com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, michal.simek@....com, harini.katakam@....com,
        git@....com, radhey.shyam.pandey@....com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] dt-bindings: net: xilinx_gmii2rgmii: Convert to json
 schema

On Thu, Jul 13, 2023 at 08:53:34PM +0200, Krzysztof Kozlowski wrote:
> On 13/07/2023 17:59, Andrew Lunn wrote:
> >>> +examples:
> >>> +  - |
> >>> +    mdio {
> >>> +        #address-cells = <1>;
> >>> +        #size-cells = <0>;
> >>> +        phy: ethernet-phy@0 {
> >>> +            reg = <0>;
> >>> +        };
> >>
> >> Drop this node, quite obvious.
> > 
> > Dumb question. Isn't it needed since it is referenced by phy-handle =
> > <&phy> below. Without it, the fragment is not valid DT and so the
> > checking tools will fail?
> 
> No, because the example is compiled with silencing missing phandles.

Ah, thanks.

This is a rather odd device, there is no other like it in mainline, so
i think having that PHY is useful, even if you think it is obvious
what is going on here.

     Andrew