lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 13 Jul 2023 13:06:41 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     linux-renesas-soc@...r.kernel.org, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: renesas_sdhi: remove outdated indentation

On Wed, 12 Jul 2023 at 16:01, Wolfram Sang
<wsa+renesas@...g-engineering.com> wrote:
>
> Using tabs to make a structure initialization more readable is not
> considered helpful. Remove the final appearance from this driver.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>
> My eyes always stumble over this...
>
>  drivers/mmc/host/renesas_sdhi_core.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index 2d5ef9c37d76..10dbdb4abc93 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -983,12 +983,12 @@ int renesas_sdhi_probe(struct platform_device *pdev,
>
>         }
>
> -       host->write16_hook      = renesas_sdhi_write16_hook;
> -       host->clk_enable        = renesas_sdhi_clk_enable;
> -       host->clk_disable       = renesas_sdhi_clk_disable;
> -       host->set_clock         = renesas_sdhi_set_clock;
> -       host->multi_io_quirk    = renesas_sdhi_multi_io_quirk;
> -       host->dma_ops           = dma_ops;
> +       host->write16_hook = renesas_sdhi_write16_hook;
> +       host->clk_enable = renesas_sdhi_clk_enable;
> +       host->clk_disable = renesas_sdhi_clk_disable;
> +       host->set_clock = renesas_sdhi_set_clock;
> +       host->multi_io_quirk = renesas_sdhi_multi_io_quirk;
> +       host->dma_ops = dma_ops;
>
>         if (sdhi_has_quirk(priv, hs400_disabled))
>                 host->mmc->caps2 &= ~(MMC_CAP2_HS400 | MMC_CAP2_HS400_ES);
> --
> 2.30.2
>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ