linux-kernel - Re: [PATCH 3/3] mmc: pxamci: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFqEZzph0B3gdy-UVvg_1YytoH3jVtSnv-AYCy9m9FG9cw@mail.gmail.com>
Date:   Thu, 13 Jul 2023 13:06:50 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Yangtao Li <frank.li@...o.com>
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] mmc: pxamci: Use devm_platform_get_and_ioremap_resource()

On Tue, 4 Jul 2023 at 15:19, Yangtao Li <frank.li@...o.com> wrote:
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yangtao Li <frank.li@...o.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/pxamci.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
> index 2a988f942b6c..1142cd2368f6 100644
> --- a/drivers/mmc/host/pxamci.c
> +++ b/drivers/mmc/host/pxamci.c
> @@ -612,7 +612,6 @@ static int pxamci_probe(struct platform_device *pdev)
>         struct resource *r;
>         int ret, irq;
>
> -       r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>         irq = platform_get_irq(pdev, 0);
>         if (irq < 0)
>                 return irq;
> @@ -685,14 +684,14 @@ static int pxamci_probe(struct platform_device *pdev)
>         }
>
>         spin_lock_init(&host->lock);
> -       host->res = r;
>         host->imask = MMC_I_MASK_ALL;
>
> -       host->base = devm_ioremap_resource(dev, r);
> +       host->base = devm_platform_get_and_ioremap_resource(pdev, 0, &r);
>         if (IS_ERR(host->base)) {
>                 ret = PTR_ERR(host->base);
>                 goto out;
>         }
> +       host->res = r;
>
>         /*
>          * Ensure that the host controller is shut down, and setup
> --
> 2.39.0
>