[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJZ5v0ixPUo1t8A4Qv7kAdxU3n7o4WxSFD0GyKom_ZJq_g2wtQ@mail.gmail.com>
Date: Fri, 14 Jul 2023 20:59:19 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Yangtao Li <frank.li@...o.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
Viresh Kumar <viresh.kumar@...aro.org>,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 13/19] cpufreq: pcc-cpufreq: Convert to platform remove
callback returning void
On Wed, Jul 12, 2023 at 11:34 AM Yangtao Li <frank.li@...o.com> wrote:
>
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Signed-off-by: Yangtao Li <frank.li@...o.com>
Acked-by: Rafael J. Wysocki <rafael@...nel.org>
or please let me know if you want me to pick ths up.
Thanks!
> ---
> drivers/cpufreq/pcc-cpufreq.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c
> index 73efbcf5513b..84fe37def0f1 100644
> --- a/drivers/cpufreq/pcc-cpufreq.c
> +++ b/drivers/cpufreq/pcc-cpufreq.c
> @@ -608,22 +608,20 @@ static int __init pcc_cpufreq_probe(struct platform_device *pdev)
> return ret;
> }
>
> -static int pcc_cpufreq_remove(struct platform_device *pdev)
> +static void pcc_cpufreq_remove(struct platform_device *pdev)
> {
> cpufreq_unregister_driver(&pcc_cpufreq_driver);
>
> pcc_clear_mapping();
>
> free_percpu(pcc_cpu_info);
> -
> - return 0;
> }
>
> static struct platform_driver pcc_cpufreq_platdrv = {
> .driver = {
> .name = "pcc-cpufreq",
> },
> - .remove = pcc_cpufreq_remove,
> + .remove_new = pcc_cpufreq_remove,
> };
>
> static int __init pcc_cpufreq_init(void)
> --
> 2.39.0
>
Powered by blists - more mailing lists