[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230720103235.ao3664ibqjksun5u@vireshk-i7>
Date: Thu, 20 Jul 2023 16:02:35 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Yangtao Li <frank.li@...o.com>
Cc: Yangtao Li <tiny.windzz@...il.com>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>, linux-pm@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/19] cpufreq: sun50i: Convert to platform remove
callback returning void
On 12-07-23, 17:33, Yangtao Li wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Signed-off-by: Yangtao Li <frank.li@...o.com>
> ---
> drivers/cpufreq/sun50i-cpufreq-nvmem.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Applied all the patches. Thanks.
--
viresh
Powered by blists - more mailing lists