linux-kernel - Re: [PATCH v2] net: lan966x: fix parameter check in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 14 Jul 2023 10:18:14 +0200
From:   Horatiu Vultur <horatiu.vultur@...rochip.com>
To:     Minjie Du <duminjie@...o.com>
CC:     <dkirjanov@...e.de>,
        "maintainer:MICROCHIP LAN966X ETHERNET DRIVER" 
        <UNGLinuxDriver@...rochip.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Richard Cochran <richardcochran@...il.com>,
        "open list:MICROCHIP LAN966X ETHERNET DRIVER" 
        <netdev@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>,
        <opensource.kernel@...o.com>
Subject: Re: [PATCH v2] net: lan966x: fix parameter check in two functions

The 07/14/2023 09:22, Minjie Du wrote:

Hi Minjie,

> 
> Make IS_ERR_OR_NULL() judge the vcap_get_rule() function return.
> in lan966x_ptp_add_trap() and lan966x_ptp_del_trap().
> 
> Fixes: 72df3489fb10 ("net: lan966x: Add ptp trap rules")
> Signed-off-by: Minjie Du <duminjie@...o.com>

You forgot to set the target tree in the subject. You can do that when
you create the patch using the command:
git format-patch ... --subject-prefix "PATCH net" ...

Other than that, it looks OK:
Reviewed-by: Horatiu Vultur <horatiu.vultur@...rochip.com>

> ---
>  drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c b/drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c
> index 266a21a2d..59dd14247 100644
> --- a/drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c
> +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c
> @@ -59,7 +59,7 @@ static int lan966x_ptp_add_trap(struct lan966x_port *port,
>         int err;
> 
>         vrule = vcap_get_rule(lan966x->vcap_ctrl, rule_id);
> -       if (vrule) {
> +       if (!IS_ERR_OR_NULL(vrule)) {
>                 u32 value, mask;
> 
>                 /* Just modify the ingress port mask and exit */
> @@ -106,7 +106,7 @@ static int lan966x_ptp_del_trap(struct lan966x_port *port,
>         int err;
> 
>         vrule = vcap_get_rule(lan966x->vcap_ctrl, rule_id);
> -       if (!vrule)
> +       if (IS_ERR_OR_NULL(vrule))
>                 return -EEXIST;
> 
>         vcap_rule_get_key_u32(vrule, VCAP_KF_IF_IGR_PORT_MASK, &value, &mask);
> --
> 2.39.0
> 
> 

-- 
/Horatiu