[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZLEK1AYMmj24rIph@gondor.apana.org.au>
Date: Fri, 14 Jul 2023 18:44:04 +1000
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Jia Jie Ho <jiajie.ho@...rfivetech.com>
Cc: "David S . Miller" <davem@...emloft.net>,
linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] crypto: starfive - Add AES skcipher and aead support
On Thu, Jul 06, 2023 at 11:27:37AM +0800, Jia Jie Ho wrote:
> Adding AES skcipher and aead support to Starfive crypto module.
> Skcipher modes of operation include ecb, cbc, ctr, ofb, cfb. Aead modes
> include ccm and gcm.
>
> Co-developed-by: Huan Feng <huan.feng@...rfivetech.com>
> Signed-off-by: Huan Feng <huan.feng@...rfivetech.com>
> Signed-off-by: Jia Jie Ho <jiajie.ho@...rfivetech.com>
> ---
> drivers/crypto/starfive/Kconfig | 2 +
> drivers/crypto/starfive/Makefile | 2 +-
> drivers/crypto/starfive/jh7110-aes.c | 1034 +++++++++++++++++++++++++
> drivers/crypto/starfive/jh7110-cryp.c | 36 +-
> drivers/crypto/starfive/jh7110-cryp.h | 64 ++
> 5 files changed, 1131 insertions(+), 7 deletions(-)
> create mode 100644 drivers/crypto/starfive/jh7110-aes.c
This doesn't compile:
CC [M] drivers/crypto/starfive/jh7110-cryp.o
CC [M] drivers/crypto/starfive/jh7110-hash.o
CC [M] drivers/crypto/starfive/jh7110-rsa.o
CC [M] drivers/crypto/starfive/jh7110-aes.o
In file included from ../drivers/crypto/starfive/jh7110-aes.c:13:
../drivers/crypto/starfive/jh7110-cryp.h:184:49: error: field ‘aes_done’ has incomplete type
184 | struct tasklet_struct aes_done;
| ^~~~~~~~
../drivers/crypto/starfive/jh7110-cryp.h:185:49: error: field ‘hash_done’ has incomplete type
185 | struct tasklet_struct hash_done;
| ^~~~~~~~~
make[6]: *** [../scripts/Makefile.build:243: drivers/crypto/starfive/jh7110-aes.o] Error 1
make[6]: *** Waiting for unfinished jobs....
Cheers,
--
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists