linux-kernel - RE: [PATCH] crypto: starfive - Add AES skcipher and aead support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1cd932eb3234436394bf46cfebc1df39@EXMBX068.cuchost.com>
Date:   Mon, 17 Jul 2023 01:47:58 +0000
From:   JiaJie Ho <jiajie.ho@...rfivetech.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     "David S . Miller" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Subject: RE: [PATCH] crypto: starfive - Add AES skcipher and aead support

> This doesn't compile:
> 
>   CC [M]  drivers/crypto/starfive/jh7110-cryp.o
>   CC [M]  drivers/crypto/starfive/jh7110-hash.o
>   CC [M]  drivers/crypto/starfive/jh7110-rsa.o
>   CC [M]  drivers/crypto/starfive/jh7110-aes.o
> In file included from ../drivers/crypto/starfive/jh7110-aes.c:13:
> ../drivers/crypto/starfive/jh7110-cryp.h:184:49: error: field ‘aes_done’ has
> incomplete type
>   184 |         struct tasklet_struct                   aes_done;
>       |                                                 ^~~~~~~~
> ../drivers/crypto/starfive/jh7110-cryp.h:185:49: error: field ‘hash_done’ has
> incomplete type
>   185 |         struct tasklet_struct                   hash_done;
>       |                                                 ^~~~~~~~~
> make[6]: *** [../scripts/Makefile.build:243: drivers/crypto/starfive/jh7110-
> aes.o] Error 1
> make[6]: *** Waiting for unfinished jobs....
> 

Hi Herbert,
Thanks for reviewing the patch.
I found out that it's missing interrupt.h include. 
It is weird that the compile error did not show in the original driver and on my local build.
I'll fix this in the next version.

Thanks,
Jia Jie