linux-kernel - Re: [PATCH v6] crypto: qat - replace the if statement with min()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZLEN5qmCbcXSQ0G8@gondor.apana.org.au>
Date:   Fri, 14 Jul 2023 18:57:10 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     You Kangren <youkangren@...o.com>
Cc:     Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Adam Guerin <adam.guerin@...el.com>,
        Srinivas Kerekare <srinivas.kerekare@...el.com>,
        Damian Muszynski <damian.muszynski@...el.com>,
        "open list:QAT DRIVER" <qat-linux@...el.com>,
        "open list:CRYPTO API" <linux-crypto@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        opensource.kernel@...o.com, luhongfei@...o.com,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v6] crypto: qat - replace the if statement with min()

On Tue, Jul 04, 2023 at 08:45:32PM +0800, You Kangren wrote:
> Mark UWORD_CPYBUF_SIZE with U suffix to make its type the same
> with words_num. Then replace the if statement with min() in
> qat_uclo_wr_uimage_raw_page() to make code shorter.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Signed-off-by: You Kangren <youkangren@...o.com>
> ---
> Changelog:
> v5->v6:
> - Remove the unnecessary Fixes tag of the patch
> - Change the first letter of "replace" in the headline of the commit message to lower case
> 
> v4->v5: 
> - Add the Fixes and Reviewed-by tags of the patch
> - Add the version update information of the patch
> 
> v3->v4:
> - Remove the header file <linux/minmax.h> in v3
> 
> v2->v3:
> - Add a header file <linux/minmax.h>
> - Mark UWORD_CPYBUF_SIZE with U suffix
> - Change min_t() to min() in qat_uclo_wr_uimage_raw_page()
> 
> v1->v2:
> - Change min() to min_t() in qat_uclo_wr_uimage_raw_page()
> 
>  drivers/crypto/intel/qat/qat_common/qat_uclo.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt