linux-kernel - Re: [PATCH v4 03/11] PCI: pciehp: Use RMW accessors for changing LNKCTL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Jul 2023 11:58:06 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     linux-pci@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Lukas Wunner <lukas@...ner.de>,
        Jesse Barnes <jbarnes@...tuousgeek.org>,
        Yinghai Lu <yinghai@...nel.org>, linux-kernel@...r.kernel.org,
        Dean Luick <dean.luick@...nelisnetworks.com>,
        Jonas Dreßler <verdre@...d.nl>,
        stable@...r.kernel.org
Subject: Re: [PATCH v4 03/11] PCI: pciehp: Use RMW accessors for changing
 LNKCTL

On Thu, Jul 13, 2023 at 03:44:57PM +0300, Ilpo Järvinen wrote:
> As hotplug is not the only driver touching LNKCTL, use the RMW
> capability accessor which handles concurrent changes correctly.

...

> +	pcie_capability_clear_and_set_word(pdev, PCI_EXP_LNKCTL,
> +					   PCI_EXP_LNKCTL_LD,
> +					   !enable ? PCI_EXP_LNKCTL_LD : 0);

					   enable ? 0 : PCI_EXP_LNKCTL_LD);

easier to read and get.

-- 
With Best Regards,
Andy Shevchenko