linux-kernel - Re: [v3,18/18] fbdev: Document that framebuffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <809f8391-c9e2-4432-12ec-9921360e3c8e@linux.dev>
Date:   Fri, 14 Jul 2023 18:17:59 +0800
From:   Sui JIngfeng <sui.jingfeng@...ux.dev>
To:     Thomas Zimmermann <tzimmermann@...e.de>, deller@....de,
        javierm@...hat.com
Cc:     linux-fbdev@...r.kernel.org, kvm@...r.kernel.org,
        linux-hyperv@...r.kernel.org, linux-sh@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        amd-gfx@...ts.freedesktop.org, linux-geode@...ts.infradead.org,
        dri-devel@...ts.freedesktop.org, linux-input@...r.kernel.org,
        Miguel Ojeda <ojeda@...nel.org>,
        linux-nvidia@...ts.surfsouth.com, linux-omap@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org
Subject: Re: [v3,18/18] fbdev: Document that framebuffer_alloc() returns
 zero'ed data


On 2023/7/14 15:49, Thomas Zimmermann wrote:
> Most fbdev drivers depend on framebuffer_alloc() to initialize the
> allocated memory to 0. Document this guarantee.
>
> v3:
> 	* slightly reword the sentence (Miguel)
>
> Suggested-by: Miguel Ojeda <ojeda@...nel.org>
> Signed-off-by: Thomas Zimmermann <tzimmermann@...e.de>
> Reviewed-by: Miguel Ojeda <ojeda@...nel.org>

Reviewed-by: Sui Jingfeng <suijingfeng@...ngson.cn>

> Cc: Helge Deller <deller@....de>
> ---
>   drivers/video/fbdev/core/fb_info.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/core/fb_info.c b/drivers/video/fbdev/core/fb_info.c
> index 8bdbefdd4b70..4847ebe50d7d 100644
> --- a/drivers/video/fbdev/core/fb_info.c
> +++ b/drivers/video/fbdev/core/fb_info.c
> @@ -13,7 +13,8 @@
>    *
>    * Creates a new frame buffer info structure. Also reserves @size bytes
>    * for driver private data (info->par). info->par (if any) will be
> - * aligned to sizeof(long).
> + * aligned to sizeof(long). The new instances of struct fb_info and
> + * the driver private data are both cleared to zero.
>    *
>    * Returns the new structure, or NULL if an error occurred.
>    *