linux-kernel - Re: [PATCH v3 00/18] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Jul 2023 12:24:05 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-fbdev@...r.kernel.org, kvm@...r.kernel.org,
        linux-hyperv@...r.kernel.org, linux-sh@...r.kernel.org,
        deller@....de, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
        javierm@...hat.com, dri-devel@...ts.freedesktop.org,
        linux-input@...r.kernel.org, linux-nvidia@...ts.surfsouth.com,
        linux-omap@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-geode@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org
Subject: Re: [PATCH v3 00/18] fbdev: Remove FBINFO_DEFAULT and
 FBINFO_FLAG_DEFAULT flags

Hi

Am 14.07.23 um 12:04 schrieb Geert Uytterhoeven:
> Hi Thomas,
> 
> On Fri, Jul 14, 2023 at 9:53 AM Thomas Zimmermann <tzimmermann@...e.de> wrote:
>> Remove the unused flags FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT from
>> fbdev and drivers, as briefly discussed at [1]. Both flags were maybe
>> useful when fbdev had special handling for driver modules. With
>> commit 376b3ff54c9a ("fbdev: Nuke FBINFO_MODULE"), they are both 0
>> and have no further effect.
>>
>> Patches 1 to 7 remove FBINFO_DEFAULT from drivers. Patches 2 to 5
>> split this by the way the fb_info struct is being allocated. All flags
>> are cleared to zero during the allocation.
>>
>> Patches 8 to 16 do the same for FBINFO_FLAG_DEFAULT. Patch 8 fixes
>> an actual bug in how arch/sh uses the token for struct fb_videomode,
>> which is unrelated.
>>
>> Patch 17 removes both flag constants from <linux/fb.h> and patch 18
>> documents the zero'ed memory returned by framebuffer_alloc().
>>
>> v3:
>>          * sh: include board name in commit message (Adrian)
>>          * docs: reword text (Miguel)
> 
> Thanks for the update!
> 
>>    fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers
>>    fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers
>>    fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers
>>    fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers

I wasn't happy about this either. But I could not come up with a 
description that fits into the 74-char limit for each commit. They only 
differ in the method of memory allocation. Do you have any ideas?

> 
> Four patches with the exact same one-line summary. Please make them
> unique.
> 
>>    fbdev: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
>>    fbdev: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
> 
> Two patches with the exact same one-line summary. Please make them
> unique.

Same problem here.

Best regards
Thomas

> 
> Gr{oetje,eeting}s,
> 
>                          Geert
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)