linux-kernel - Re: [PATCH v3] ntb: Remove error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <gkiohfwsrxclkgkrlvfu37kvbv72tahc6c4kvz34uh6hhwrunk@surqby5talzt>
Date:   Fri, 14 Jul 2023 17:03:27 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Wang Ming <machel@...o.com>, opensource.kernel@...o.com,
        kernel-janitors@...r.kernel.org, ntb@...ts.linux.dev,
        Allen Hubbe <allenbh@...il.com>,
        Dan Carpenter <error27@...il.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Jiasheng Jiang <jiasheng@...as.ac.cn>,
        Jon Mason <jdmason@...zu.us>,
        LKML <linux-kernel@...r.kernel.org>,
        Minjie Du <duminjie@...o.com>,
        Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH v3] ntb: Remove error checking for debugfs_create_dir()

On Fri, Jul 14, 2023 at 02:44:11PM +0200, Markus Elfring wrote:
> > > It is expected that most callers should _ignore_ the errors
> > > return by debugfs_create_dir() in tool_setup_dbgfs()
> …
> > The patch itself is correct for sure:
> > Reviewed-by: Serge Semin <fancer.lancer@...il.com>
> 

> How does such information fit to the Linux development requirement
> for imperative change descriptions?
> 
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n94

Well, the patch author does follow that rule in the subject. Regarding the
patch log body it is impossible to use the "imperative mood" always in the
entire text. In this case the explanation is pretty much clear and doesn't
use the patterns like "This patch", or any personal pronouns so IMO it's
fine to have the log as is.

> 
> 
> How do you think about to add the tag “Fixes” because of the deletion
> of an inappropriate error detection?

It doesn't fix any real bug. So there is no need in the tag.

-Serge(y)

> 
> Regards,
> Markus