linux-kernel - Re: [PATCH] hwmon: (aquacomputer_d5next) Fix incorrect PWM value readout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 15 Jul 2023 09:25:14 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Aleksa Savic <savicaleksa83@...il.com>
Cc:     linux-hwmon@...r.kernel.org, Jack Doan <me@...kdoan.com>,
        Jean Delvare <jdelvare@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (aquacomputer_d5next) Fix incorrect PWM value
 readout

On Fri, Jul 14, 2023 at 02:07:11PM +0200, Aleksa Savic wrote:
> Commit 662d20b3a5af ("hwmon: (aquacomputer_d5next) Add support for
> temperature sensor offsets") changed aqc_get_ctrl_val() to return
> the value through a parameter instead of through the return value,
> but didn't fix up a case that relied on the old behavior. Fix it
> to use the proper received value and not the return code.
> 
> Fixes: 662d20b3a5af ("hwmon: (aquacomputer_d5next) Add support for temperature sensor offsets")
> Cc: stable@...r.kernel.org
> Signed-off-by: Aleksa Savic <savicaleksa83@...il.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/aquacomputer_d5next.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/aquacomputer_d5next.c b/drivers/hwmon/aquacomputer_d5next.c
> index a981f7086114..a997dbcb563f 100644
> --- a/drivers/hwmon/aquacomputer_d5next.c
> +++ b/drivers/hwmon/aquacomputer_d5next.c
> @@ -1027,7 +1027,7 @@ static int aqc_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
>  			if (ret < 0)
>  				return ret;
>  
> -			*val = aqc_percent_to_pwm(ret);
> +			*val = aqc_percent_to_pwm(*val);
>  			break;
>  		}
>  		break;