linux-kernel - Re: [PATCH] bus: imx-weim: fix to avoid potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5BByJsCOCpQ9WZqMWP7qmh7x3N06wD9VhpWMjoi4hg2ag@mail.gmail.com>
Date:   Sat, 15 Jul 2023 13:38:09 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Zhang Shurong <zhang_shurong@...mail.com>
Cc:     shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        linux-imx@....com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bus: imx-weim: fix to avoid potential NULL pointer dereference

Hi Zhang,

On Sat, Jul 15, 2023 at 12:21 PM Zhang Shurong
<zhang_shurong@...mail.com> wrote:
>
> of_match_device() may fail and returns a NULL pointer.
>
> Fix this by checking the return value of of_match_device.
>
> Fixes: 3f98b6baad63 ("drivers: bus: imx-weim: Add support for i.MX1/21/25/27/31/35/50/51/53")
> Signed-off-by: Zhang Shurong <zhang_shurong@...mail.com>
> ---
>  drivers/bus/imx-weim.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 52a5d0447390..65402bb60c18 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -202,15 +202,19 @@ static int weim_timing_setup(struct device *dev, struct device_node *np,
>
>  static int weim_parse_dt(struct platform_device *pdev)
>  {
> -       const struct of_device_id *of_id = of_match_device(weim_id_table,
> -                                                          &pdev->dev);
> -       const struct imx_weim_devtype *devtype = of_id->data;
> +       const struct of_device_id *of_id;
> +       const struct imx_weim_devtype *devtype;
>         int ret = 0, have_child = 0;
>         struct device_node *child;
>         struct weim_priv *priv;
>         void __iomem *base;
>         u32 reg;
>
> +       of_id = of_match_device(weim_id_table, &pdev->dev);
> +       if (!of_id)
> +               return -EINVAL;

If there is no match the driver will not probe in the first place.

I don't think this check is needed.