linux-kernel - Re: [PATCH] shmem: set variable shmem_mark_dquot_dirty and shmem_dquot_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZLIPDVIw/6cZfKrz@casper.infradead.org>
Date:   Sat, 15 Jul 2023 04:14:21 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Tom Rix <trix@...hat.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] shmem: set variable shmem_mark_dquot_dirty and
 shmem_dquot_write_info storage-class-specifier to static

On Fri, Jul 14, 2023 at 05:51:13PM -0400, Tom Rix wrote:
> smatch reports
> mm/shmem_quota.c:318:5: warning: symbol 'shmem_mark_dquot_dirty'
>   was not declared. Should it be static?
> mm/shmem_quota.c:323:5: warning: symbol 'shmem_dquot_write_info'
>   was not declared. Should it be static?
> 
> These variables are only used in their defining file, so it should be static.

These are functions, not variables, and you're the third person to send
this patch today.