linux-kernel - [PATCH v2 0/2] add mcp4728 I2C DAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <0414e2e4-a17d-3435-e9e7-35b110233a6d@gmail.com>
Date:   Sun, 16 Jul 2023 23:26:43 +0200
From:   Andrea Collamati <andrea.collamati@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     Krzysztof Kozlowski <krzk@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        William Breathitt Gray <william.gray@...aro.org>,
        Angelo Dureghello <angelo.dureghello@...esys.com>,
        Fabio Estevam <festevam@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "andrea.collamati@...il.com" <andrea.collamati@...il.com>
Subject: [PATCH v2 0/2] add mcp4728 I2C DAC driver

Dear Krzysztof

I release a V2 version. I hope I have understood all your requests.
See below.

> 2. Please use scripts/get_maintainers.pl to get a list of necessary
> people and lists to CC (and consider --no-git-fallback argument). It
> might happen, that command when run on an older kernel, gives you
> outdated entries. Therefore please be sure you base your patches on
> recent Linux kernel.
>
I was using branch master git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git but

I saw it was too old. I switched to branch testing.
> 6. mcp or MCP? What is this? Proper title is missing... also no
> description.
>
I don't know whether using small o capital letters. Usually manufacturers use capital letter to identify the component
but kernel drivers use lowercase in code.
>
> Shouldn't this binding be just merged with existing mcp4725? Are you
> sure it's not similar device, IOW, are you sure you do not have vref supply?
>
Unfortunately they are not that similar. MCP4728 has two vref choices:

- Use Vdd (power supply) as Vref

- User Internal 2.048 V Vref source.


Andrea Collamati (2):
  dt-bindings: iio: dac: add mcp4728.yaml
  iio: add mcp4728 I2C DAC driver

 .../bindings/iio/dac/microchip,mcp4728.yaml   | 42 +++++++++
 drivers/iio/dac/mcp4728.c                     | 93 +++++++++----------
 2 files changed, 86 insertions(+), 49 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml

-- 
2.34.1