[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46bccbca-1343-aed4-4dfe-eb5182b8f6a1@linaro.org>
Date: Mon, 17 Jul 2023 09:17:29 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Andrea Collamati <andrea.collamati@...il.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: Krzysztof Kozlowski <krzk@...nel.org>,
Jonathan Cameron <jic23@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
William Breathitt Gray <william.gray@...aro.org>,
Angelo Dureghello <angelo.dureghello@...esys.com>,
Fabio Estevam <festevam@...il.com>,
Lukas Bulwahn <lukas.bulwahn@...il.com>,
"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/2] add mcp4728 I2C DAC driver​
On 16/07/2023 23:26, Andrea Collamati wrote:
> Dear Krzysztof
>
> I release a V2 version. I hope I have understood all your requests.
> See below.
>
>> 2. Please use scripts/get_maintainers.pl to get a list of necessary
>> people and lists to CC (and consider --no-git-fallback argument). It
>> might happen, that command when run on an older kernel, gives you
>> outdated entries. Therefore please be sure you base your patches on
>> recent Linux kernel.
>>
> I was using branch master git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git but
Should be fine. I still doubt that you used it, though. If you got
Conor's email, then for sure you should have got my email.
>
> I saw it was too old. I switched to branch testing.
>> 6. mcp or MCP? What is this? Proper title is missing... also no
>> description.
>>
> I don't know whether using small o capital letters. Usually manufacturers use capital letter to identify the component
> but kernel drivers use lowercase in code.
Use what is in datasheet.
>>
>> Shouldn't this binding be just merged with existing mcp4725? Are you
>> sure it's not similar device, IOW, are you sure you do not have vref supply?
>>
> Unfortunately they are not that similar. MCP4728 has two vref choices:
>
> - Use Vdd (power supply) as Vref
>
> - User Internal 2.048 V Vref source.
Exactly the same as existing mcp4726, so what is the problem?
Best regards,
Krzysztof
Powered by blists - more mailing lists