[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <548cb723-6bce-4360-75f3-b4ec822bbf2c@linux.alibaba.com>
Date: Tue, 18 Jul 2023 00:16:46 +0800
From: Gao Xiang <hsiangkao@...ux.alibaba.com>
To: Jingbo Xu <jefflexu@...ux.alibaba.com>, chao@...nel.org,
huyue2@...lpad.com, linux-erofs@...ts.ozlabs.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] erofs: deprecate superblock checksum feature
On 2023/7/17 19:27, Jingbo Xu wrote:
> Later we're going to try the self-contained image verification.
> The current superblock checksum feature has quite limited
> functionality, instead, merkle trees can provide better protection
> for image integrity.
>
> xxhash is also used in the following xattr name filter feature. It is
> redundant for one filesystem to rely on two hashing algorithms at the
> same time.
>
> Since the superblock checksum is a compatible feature, just deprecate
> it now.
>
> Signed-off-by: Jingbo Xu <jefflexu@...ux.alibaba.com>
I tend to agree on this since it slightly impacts mount time too:
Reviewed-by: Gao Xiang <hsiangkao@...ux.alibaba.com>
Thanks,
Gao Xiang
Powered by blists - more mailing lists