[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 17 Jul 2023 19:38:52 +0200
From: Ahmad Fatoum <a.fatoum@...gutronix.de>
To: Marco Felsch <m.felsch@...gutronix.de>
Cc: robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, shawnguo@...nel.org, kernel@...gutronix.de,
festevam@...il.com, linux-imx@....com,
laurent.pinchart@...asonboard.com, dan.scally@...asonboard.com,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 2/4] dt-bindings: arm: fsl: fix DEBIX binding
On 17.07.23 19:24, Marco Felsch wrote:
> On 23-07-17, Ahmad Fatoum wrote:
>> On 17.07.23 18:51, Marco Felsch wrote:
>>> The current imx8mp-debix-model-a.dts uses all three compatibles. Fix the
>>> corresponding bindings by adding an own entry for it. Mark
>>> polyhex,imx8mp-debix as deprecated but keep it within the dts file since
>>> we already have a user for it [1].
>>>
>>> [1] https://elixir.bootlin.com/barebox/v2023.07.1/source/arch/arm/ \
>>> boards/polyhex-debix/board.c#L38
>>>
>>> Signed-off-by: Marco Felsch <m.felsch@...gutronix.de>
>>> ---
>>> Changelog:
>>>
>>> v2:
>>> - deprecate polyhex,imx8mp-debix
>>>
>>> Documentation/devicetree/bindings/arm/fsl.yaml | 10 ++++++++--
>>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> index 15d4110840654..b29974e3c30b3 100644
>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> @@ -1019,8 +1019,6 @@ properties:
>>> - dmo,imx8mp-data-modul-edm-sbc # i.MX8MP eDM SBC
>>> - fsl,imx8mp-evk # i.MX8MP EVK Board
>>> - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board
>>> - - polyhex,imx8mp-debix # Polyhex Debix boards
>>> - - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board
>>> - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules
>>> - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT
>>> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules
>>> @@ -1054,6 +1052,14 @@ properties:
>>> - const: phytec,imx8mp-phycore-som # phyCORE-i.MX8MP SoM
>>> - const: fsl,imx8mp
>>>
>>> + - description: Polyhex DEBIX i.MX8MP based SBCs
>>> + items:
>>> + - enum:
>>> + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board
>>> + - const: polyhex,imx8mp-debix # Polyhex Debix boards
>>> + deprecated: true
>>
>> I don't see why you need to deprecate this. Can't you just change the comment
>> to read "Polyhex i.MX8MP SBCs" or similar?
>
> This was suggested by Krzysztof, since polyhex,imx8mp-debix was to
> generic. I can keep it without the deprecation notice and just change
> the comment since we need to keep dts compatible anyway.
I agree that using it as compatible for both SBC and SoMs, when the boards
aren't based on the SoM isn't useful. I still think it's useful to have
a compatible for "Debix i.MX8MP SBCs" that spans current lineup of Model A,
Model B, B SE and possible future compatibles.
Cheers,
Ahmad
>
> Regards,
> Marco
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists