linux-kernel - Re: [PATCH] cgroup: remove cgrp->kn check in css_populate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZLWMHgssvfK-nQXR@slm.duckdns.org>
Date:   Mon, 17 Jul 2023 08:44:46 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Kamalesh Babulal <kamalesh.babulal@...cle.com>
Cc:     Zefan Li <lizefan.x@...edance.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Tom Hromatka <tom.hromatka@...cle.com>,
        cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cgroup: remove cgrp->kn check in css_populate_dir()

On Mon, Jul 17, 2023 at 08:09:23PM +0530, Kamalesh Babulal wrote:
> cgroup_create() creates cgrp and assigns the kernfs_node to cgrp->kn,
> then cgroup_mkdir() populates base and csses cft file by calling
> css_populate_dir() and cgroup_apply_control_enable() with a valid
> cgrp->kn. Check for NULL cgrp->kn, will always be false, remove it.
> 
> Signed-off-by: Kamalesh Babulal <kamalesh.babulal@...cle.com>

Applied to cgroup/for-6.6.

Thanks.

-- 
tejun