[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230717143923.1781747-1-kamalesh.babulal@oracle.com>
Date: Mon, 17 Jul 2023 20:09:23 +0530
From: Kamalesh Babulal <kamalesh.babulal@...cle.com>
To: Tejun Heo <tj@...nel.org>, Zefan Li <lizefan.x@...edance.com>,
Johannes Weiner <hannes@...xchg.org>
Cc: Tom Hromatka <tom.hromatka@...cle.com>, cgroups@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] cgroup: remove cgrp->kn check in css_populate_dir()
cgroup_create() creates cgrp and assigns the kernfs_node to cgrp->kn,
then cgroup_mkdir() populates base and csses cft file by calling
css_populate_dir() and cgroup_apply_control_enable() with a valid
cgrp->kn. Check for NULL cgrp->kn, will always be false, remove it.
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@...cle.com>
---
kernel/cgroup/cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index f55a40db065f..5294fbfb4bf4 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -1736,7 +1736,7 @@ static int css_populate_dir(struct cgroup_subsys_state *css)
struct cftype *cfts, *failed_cfts;
int ret;
- if ((css->flags & CSS_VISIBLE) || !cgrp->kn)
+ if (css->flags & CSS_VISIBLE)
return 0;
if (!css->ss) {
base-commit: fdf0eaf11452d72945af31804e2a1048ee1b574c
--
2.34.3
Powered by blists - more mailing lists