linux-kernel - Re: [PATCH v4 0/3] Add support for WDIOF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Jul 2023 06:28:44 +0000
From:   "Li, Hua Qian" <HuaQian.Li@...mens.com>
To:     "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
CC:     "kristo@...nel.org" <kristo@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "huaqianlee@...il.com" <huaqianlee@...il.com>,
        "nm@...com" <nm@...com>, "vigneshr@...com" <vigneshr@...com>,
        "Kiszka, Jan" <jan.kiszka@...mens.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "Su, Bao Cheng" <baocheng.su@...mens.com>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>
Subject: Re: [PATCH v4 0/3] Add support for WDIOF_CARDRESET on TI AM65x

On Mon, 2023-07-17 at 14:23 +0800, Hua Qian Li wrote:
> On Mon, 2023-07-17 at 08:16 +0200, Krzysztof Kozlowski wrote:
> > On 17/07/2023 06:07, huaqian.li@...mens.com wrote:
> > > From: Li Hua Qian <huaqian.li@...mens.com>
> > > 
> > > The watchdog hardware of TI AM65X platform does not support
> > > WDIOF_CARDRESET feature, add a reserved memory to save the
> > > watchdog
> > > reset cause, to know if the board reboot is due to a watchdog
> > > reset.
> > > 
> > > Signed-off-by: Li Hua Qian <huaqian.li@...mens.com>
> > > ---
> > > Changes in v4:
> > > - Fix the coding style.
> > > - Add usage note for the reserved memory.
> > > - Link to v3:
> > >  
> > > https://lore.kernel.org/linux-watchdog/20230713095127.1230109-1-huaqian.li@siemens.com
> > 
> > Much more changed. You added example in the bindings which no one
> > asked
> > for. Then you added multiple fake review tags to all the patches.
> > 
> > Best regards,
> > Krzysztof
> > 
> Hi,
> 
> Sorry for the wrong statement. I missed some key information and
> missunderstood `Reviewed-by`, I treated `Reviewed-by` as `Who
> has reviewed`.
> 
> Best regards,
> Li Hua Qian
By the way, `Much more changes` came from the following message which
was commented on [PATCH v3 0/3] Add support for WDIOF_CARDRESET on TI
AM65x:


One thing I keep wondering about: What prevents the Linux kernel from
treating the special memory area like normal memory ? I would have
expected
some usage note, such as that the memory area must be reported as
reserved
to the kernel, but I don't see anything like that.

Guenter