linux-kernel - [PATCH] scsi: Convert snprintf to scnprintf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <a9a7b9b6cfe135a74b9fb1aa11e6bea7@208suo.com>
Date:   Mon, 17 Jul 2023 14:44:12 +0800
From:   hanyu001@...suo.com
To:     jejb@...ux.ibm.com, martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] scsi: Convert snprintf to scnprintf

Fix the following coccicheck warnings:

./drivers/scsi/myrs.c:1411:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/myrs.c:1193:9-17: WARNING: use scnprintf or sprintf
./drivers/scsi/myrs.c:1316:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/myrs.c:1401:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/myrs.c:1491:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/myrs.c:1421:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/myrs.c:1391:8-16: WARNING: use scnprintf or sprintf
./drivers/scsi/myrs.c:1061:9-17: WARNING: use scnprintf or sprintf
./drivers/scsi/myrs.c:942:9-17: WARNING: use scnprintf or sprintf
./drivers/scsi/myrs.c:1089:9-17: WARNING: use scnprintf or sprintf
./drivers/scsi/myrs.c:1306:8-16: WARNING: use scnprintf or sprintf

Signed-off-by: ztt <1549089851@...com>
---
  drivers/scsi/myrs.c | 22 +++++++++++-----------
  1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/scsi/myrs.c b/drivers/scsi/myrs.c
index a1eec65a9713..ced1d2fbd862 100644
--- a/drivers/scsi/myrs.c
+++ b/drivers/scsi/myrs.c
@@ -939,7 +939,7 @@ static ssize_t raid_state_show(struct device *dev,
      int ret;

      if (!sdev->hostdata)
-        return snprintf(buf, 16, "Unknown\n");
+        return scnprintf(buf, 16, "Unknown\n");

      if (sdev->channel >= cs->ctlr_info->physchan_present) {
          struct myrs_ldev_info *ldev_info = sdev->hostdata;
@@ -1058,7 +1058,7 @@ static ssize_t raid_level_show(struct device *dev,
      const char *name = NULL;

      if (!sdev->hostdata)
-        return snprintf(buf, 16, "Unknown\n");
+        return scnprintf(buf, 16, "Unknown\n");

      if (sdev->channel >= cs->ctlr_info->physchan_present) {
          struct myrs_ldev_info *ldev_info;
@@ -1086,7 +1086,7 @@ static ssize_t rebuild_show(struct device *dev,
      unsigned char status;

      if (sdev->channel < cs->ctlr_info->physchan_present)
-        return snprintf(buf, 32, "physical device - not rebuilding\n");
+        return scnprintf(buf, 32, "physical device - not 
rebuilding\n");

      ldev_info = sdev->hostdata;
      ldev_num = ldev_info->ldev_num;
@@ -1190,7 +1190,7 @@ static ssize_t consistency_check_show(struct 
device *dev,
      unsigned short ldev_num;

      if (sdev->channel < cs->ctlr_info->physchan_present)
-        return snprintf(buf, 32, "physical device - not checking\n");
+        return scnprintf(buf, 32, "physical device - not checking\n");

      ldev_info = sdev->hostdata;
      if (!ldev_info)
@@ -1303,7 +1303,7 @@ static ssize_t serial_show(struct device *dev,

      memcpy(serial, cs->ctlr_info->serial_number, 16);
      serial[16] = '\0';
-    return snprintf(buf, 16, "%s\n", serial);
+    return scnprintf(buf, 16, "%s\n", serial);
  }
  static DEVICE_ATTR_RO(serial);

@@ -1313,7 +1313,7 @@ static ssize_t ctlr_num_show(struct device *dev,
      struct Scsi_Host *shost = class_to_shost(dev);
      struct myrs_hba *cs = shost_priv(shost);

-    return snprintf(buf, 20, "%d\n", cs->host->host_no);
+    return scnprintf(buf, 20, "%d\n", cs->host->host_no);
  }
  static DEVICE_ATTR_RO(ctlr_num);

@@ -1388,7 +1388,7 @@ static ssize_t model_show(struct device *dev,
      struct Scsi_Host *shost = class_to_shost(dev);
      struct myrs_hba *cs = shost_priv(shost);

-    return snprintf(buf, 28, "%s\n", cs->model_name);
+    return scnprintf(buf, 28, "%s\n", cs->model_name);
  }
  static DEVICE_ATTR_RO(model);

@@ -1398,7 +1398,7 @@ static ssize_t ctlr_type_show(struct device *dev,
      struct Scsi_Host *shost = class_to_shost(dev);
      struct myrs_hba *cs = shost_priv(shost);

-    return snprintf(buf, 4, "%d\n", cs->ctlr_info->ctlr_type);
+    return scnprintf(buf, 4, "%d\n", cs->ctlr_info->ctlr_type);
  }
  static DEVICE_ATTR_RO(ctlr_type);

@@ -1408,7 +1408,7 @@ static ssize_t cache_size_show(struct device *dev,
      struct Scsi_Host *shost = class_to_shost(dev);
      struct myrs_hba *cs = shost_priv(shost);

-    return snprintf(buf, 8, "%d MB\n", cs->ctlr_info->cache_size_mb);
+    return scnprintf(buf, 8, "%d MB\n", cs->ctlr_info->cache_size_mb);
  }
  static DEVICE_ATTR_RO(cache_size);

@@ -1418,7 +1418,7 @@ static ssize_t firmware_show(struct device *dev,
      struct Scsi_Host *shost = class_to_shost(dev);
      struct myrs_hba *cs = shost_priv(shost);

-    return snprintf(buf, 16, "%d.%02d-%02d\n",
+    return scnprintf(buf, 16, "%d.%02d-%02d\n",
              cs->ctlr_info->fw_major_version,
              cs->ctlr_info->fw_minor_version,
              cs->ctlr_info->fw_turn_number);
@@ -1488,7 +1488,7 @@ static ssize_t 
disable_enclosure_messages_show(struct device *dev,
      struct Scsi_Host *shost = class_to_shost(dev);
      struct myrs_hba *cs = shost_priv(shost);

-    return snprintf(buf, 3, "%d\n", cs->disable_enc_msg);
+    return scnprintf(buf, 3, "%d\n", cs->disable_enc_msg);
  }

  static ssize_t disable_enclosure_messages_store(struct device *dev,