linux-kernel - RE: [PATCH v4] wifi: rtw89: debug: Fix error handling in rtw89_debug_priv_btc_manual

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96af917c4c8d46438da1e703b2276185@realtek.com>
Date:   Mon, 17 Jul 2023 01:28:39 +0000
From:   Ping-Ke Shih <pkshih@...ltek.com>
To:     Zhang Shurong <zhang_shurong@...mail.com>,
        "Markus.Elfring@....de" <Markus.Elfring@....de>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "kvalo@...nel.org" <kvalo@...nel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4] wifi: rtw89: debug: Fix error handling in rtw89_debug_priv_btc_manual_set()



> -----Original Message-----
> From: Zhang Shurong <zhang_shurong@...mail.com>
> Sent: Saturday, July 15, 2023 9:43 PM
> To: Ping-Ke Shih <pkshih@...ltek.com>; Markus.Elfring@....de; kuba@...nel.org
> Cc: kvalo@...nel.org; linux-wireless@...r.kernel.org; linux-kernel@...r.kernel.org; Zhang Shurong
> <zhang_shurong@...mail.com>
> Subject: [PATCH v4] wifi: rtw89: debug: Fix error handling in rtw89_debug_priv_btc_manual_set()
> 
> If there is a failure during kstrtobool_from_user()
> rtw89_debug_priv_btc_manual_set should return a negative error code
> instead of returning the count directly.
> 
> Fix this bug by returning an error code instead of a count after
> a failed call of the function "kstrtobool_from_user". Moreover
> I omitted the label "out" with this source code correction.
> 
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Zhang Shurong <zhang_shurong@...mail.com>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

> ---
> Changes in v2:
> - Corrected the format of this patch
> - Used variable ret instead of goto out
> Changes in v3:
> - Improved change description
> Changes in v4:
> - Improved change description
> 

Normally, we preserve three '-' as delimiter here. I tried to use pwclient to 
apply this patch, and fortunately it works. So, I think no need to resend because
of this.

[...]