linux-kernel - Re: [PATCH v4] wifi: rtw89: debug: Fix error handling in rtw89_debug_priv_btc_manual

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <169029633544.3309254.7388836685392352626.kvalo@kernel.org>
Date:   Tue, 25 Jul 2023 14:45:37 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Zhang Shurong <zhang_shurong@...mail.com>
Cc:     pkshih@...ltek.com, Markus.Elfring@....de, kuba@...nel.org,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zhang Shurong <zhang_shurong@...mail.com>
Subject: Re: [PATCH v4] wifi: rtw89: debug: Fix error handling in
 rtw89_debug_priv_btc_manual_set()

Zhang Shurong <zhang_shurong@...mail.com> wrote:

> If there is a failure during kstrtobool_from_user()
> rtw89_debug_priv_btc_manual_set should return a negative error code
> instead of returning the count directly.
> 
> Fix this bug by returning an error code instead of a count after 
> a failed call of the function "kstrtobool_from_user". Moreover
> I omitted the label "out" with this source code correction.
> 
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Zhang Shurong <zhang_shurong@...mail.com>
> Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

Patch applied to wireless-next.git, thanks.

59b4cc439f18 wifi: rtw89: debug: Fix error handling in rtw89_debug_priv_btc_manual_set()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/tencent_1C09B99BD7DA9CAD18B00C8F0F050F540607@qq.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches