[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f1e0ecfd-b9b3-2c4b-f548-c08f7615febe@nfschina.com>
Date: Mon, 17 Jul 2023 15:30:33 +0800
From: yunchuan <yunchuan@...china.com>
To: Marc Kleine-Budde <mkl@...gutronix.de>
Cc: wg@...ndegger.com, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, uttenthaler@...-wuensche.com,
linux-can@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next v3 8/9] can: ems_pci: Remove unnecessary (void*)
conversions
On 2023/7/17 15:07, Marc Kleine-Budde wrote:
> On 17.07.2023 08:52:42, Marc Kleine-Budde wrote:
>> On 17.07.2023 11:12:21, Wu Yunchuan wrote:
>>> No need cast (void*) to (struct ems_pci_card *).
>>>
>>> Signed-off-by: Wu Yunchuan <yunchuan@...china.com>
>>> Acked-by: Marc Kleine-Budde<mkl@...gutronix.de>
>> Please add a space between my name and my e-mail address, so that it
>> reads:
>>
>> Acked-by: Marc Kleine-Budde <mkl@...gutronix.de>
>>
>> nitpick:
>> You should add your S-o-b as the last trailer.
> BTW: The threading of this series is still broken. Make sure you send
> the whole patch series with one single "git send-email" command. For
> regular contribution you might have a look at the "b4" [1] tool.
Hi,
Thanks for you suggestions, I use 'git send-email' to send patch.
I messing up the patch's order in different patchset. This might be the
reason of the broken threading.
Really sorry for this, I will take careful next time.
Wu Yunchuan
> regards,
> Marc
>
> [1] https://people.kernel.org/monsieuricon/sending-a-kernel-patch-with-b4-part-1
>
Powered by blists - more mailing lists