linux-kernel - Re: [PATCH net-next v3 8/9] can: ems_pci: Remove unnecessary (void*) conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230717-overeater-handlebar-377cac2af8ec-mkl@pengutronix.de>
Date:   Mon, 17 Jul 2023 09:33:03 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     yunchuan <yunchuan@...china.com>
Cc:     wg@...ndegger.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, uttenthaler@...-wuensche.com,
        linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next v3 8/9] can: ems_pci: Remove unnecessary (void*)
 conversions

On 17.07.2023 15:30:33, yunchuan wrote:
> 
> On 2023/7/17 15:07, Marc Kleine-Budde wrote:
> > On 17.07.2023 08:52:42, Marc Kleine-Budde wrote:
> > > On 17.07.2023 11:12:21, Wu Yunchuan wrote:
> > > > No need cast (void*) to (struct ems_pci_card *).
> > > > 
> > > > Signed-off-by: Wu Yunchuan <yunchuan@...china.com>
> > > > Acked-by: Marc Kleine-Budde<mkl@...gutronix.de>
> > > Please add a space between my name and my e-mail address, so that it
> > > reads:
> > > 
> > > Acked-by: Marc Kleine-Budde <mkl@...gutronix.de>
> > > 
> > > nitpick:
> > > You should add your S-o-b as the last trailer.
> > BTW: The threading of this series is still broken. Make sure you send
> > the whole patch series with one single "git send-email" command. For
> > regular contribution you might have a look at the "b4" [1] tool.
> 
> Hi,
> 
> Thanks for you suggestions, I use 'git send-email' to send patch.
> I messing up the patch's order in different patchset. This might be the
> reason of the broken threading.
> Really sorry for this, I will take careful next time.

You should send _all_ 9 patches in the series with a _single_ "git
send-email" command. There's no risk to mess up the order.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)